Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#53] Set up local infrastructure #61

Merged
merged 3 commits into from
Oct 25, 2023
Merged

[#53] Set up local infrastructure #61

merged 3 commits into from
Oct 25, 2023

Conversation

skgndi12
Copy link
Collaborator

@skgndi12 skgndi12 commented Sep 25, 2023 •
edited
Loading

#59

Changes

  • 로컬 인프라 설정을 위한 docker-compose 파일 추가 및 작성
  • api 프로젝트 환경 설정에 대한 내용을 담은 README 추가 및 작성.
  • .env 파일 추가 및 환경 변수 로드를 위한 스크립트 추가

@skgndi12 skgndi12 added documentation Improvements or additions to documentation enhancement New feature or request api labels Sep 25, 2023
@skgndi12 skgndi12 self-assigned this Sep 25, 2023
@skgndi12 skgndi12 linked an issue Sep 25, 2023 that may be closed by this pull request
Design repository base client #53
Closed
8 tasks
2wheeh
2wheeh reviewed Sep 26, 2023
View reviewed changes
api/README.md Outdated Show resolved Hide resolved
skgndi12
skgndi12 commented Sep 26, 2023
View reviewed changes
api/README.md Outdated Show resolved Hide resolved
api/docker/docker-compose.yml Outdated Show resolved Hide resolved
isutare412
isutare412 reviewed Sep 27, 2023
View reviewed changes
api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
api/docker/docker-compose.yml Outdated Show resolved Hide resolved
api/docker/docker-compose.yml Outdated Show resolved Hide resolved
api/docker/docker-compose.yml Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
@isutare412 isutare412 self-requested a review September 27, 2023 13:47
@skgndi12 skgndi12 force-pushed the feature/issue-53/set-up-local-postgresql branch from 71ca756 to 9730f09 Compare October 19, 2023 15:45
isutare412
isutare412 reviewed Oct 24, 2023
View reviewed changes
api/README.md Outdated Show resolved Hide resolved
api/docker-compose.yaml Outdated Show resolved Hide resolved
api/docker-compose.yaml Outdated Show resolved Hide resolved
@isutare412 isutare412 self-requested a review October 24, 2023 07:54
isutare412
isutare412 reviewed Oct 24, 2023
View reviewed changes
api/README.md Outdated Show resolved Hide resolved
@isutare412 isutare412 self-requested a review October 24, 2023 07:57
isutare412
isutare412 reviewed Oct 24, 2023
View reviewed changes
api/docker-compose.yaml Outdated Show resolved Hide resolved
@isutare412 isutare412 self-requested a review October 24, 2023 07:59
@skgndi12 skgndi12 force-pushed the feature/issue-53/set-up-local-postgresql branch from cb66f2d to a662192 Compare October 24, 2023 08:37
isutare412
isutare412 reviewed Oct 24, 2023
View reviewed changes
api/compose.yaml Outdated Show resolved Hide resolved
api/.env Outdated Show resolved Hide resolved
@isutare412 isutare412 self-requested a review October 24, 2023 08:44
2wheeh
2wheeh reviewed Oct 24, 2023
View reviewed changes
api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
isutare412
isutare412 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 👍 👍

skgndi12
skgndi12 commented Oct 25, 2023
View reviewed changes
Copy link
Collaborator Author

@skgndi12 skgndi12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README 에 대한 자세한 피드백 감사드립니다. 덕분에 문장들이 더 이해하기 편하고 깔끔해진 것 같네요! 👍

api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
api/README.md Outdated Show resolved Hide resolved
@skgndi12 skgndi12 force-pushed the feature/issue-53/set-up-local-postgresql branch from e88b9b6 to 67bf7f8 Compare October 25, 2023 03:04
2wheeh
2wheeh approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@2wheeh 2wheeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@skgndi12 skgndi12 force-pushed the feature/issue-53/set-up-local-postgresql branch from 67bf7f8 to 89e5b1a Compare October 25, 2023 12:49
@skgndi12 skgndi12 merged commit 49c21f5 into MovieReviewComment:develop Oct 25, 2023
1 check passed
@skgndi12 skgndi12 deleted the feature/issue-53/set-up-local-postgresql branch October 25, 2023 12:51
@skgndi12 skgndi12 mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2wheeh 2wheeh 2wheeh approved these changes

@isutare412 isutare412 isutare412 approved these changes

Assignees

@skgndi12 skgndi12

Labels
api documentation Improvements or additions to documentation enhancement New feature or request
Projects
Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design repository base client
3 participants
@skgndi12 @isutare412 @2wheeh