Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#28] Access logging on HTTP server #32

Merged
merged 2 commits into from
Jun 4, 2023
Merged

[#28] Access logging on HTTP server #32

merged 2 commits into from
Jun 4, 2023

Conversation

skgndi12
Copy link
Collaborator

@skgndi12 skgndi12 commented Jun 1, 2023 •
edited
Loading

Resolves #28

Changes

  • Add middleware
    • access log

@skgndi12 skgndi12 added enhancement New feature or request api labels Jun 1, 2023
@skgndi12 skgndi12 requested a review from isutare412 June 1, 2023 10:49
@skgndi12 skgndi12 self-assigned this Jun 1, 2023
@skgndi12 skgndi12 changed the base branch from main to develop June 1, 2023 10:49
@isutare412
Copy link
Collaborator

#29 와 관련된 코드는 다른 PR 에서 진행할 수 있도록 제거해주시면 감사하겠습니다.

@skgndi12 skgndi12 force-pushed the feature/issue-28/access-logging-on-http-server branch from 4ba9f65 to edacbe3 Compare June 3, 2023 03:28
@skgndi12
Copy link
Collaborator Author

skgndi12 commented Jun 3, 2023 •
edited
Loading

#29 와 관련된 코드들은 제외 후 다시 올렸습니다.
#28 의 에러메시지의 경우, #29 관련 PR 에서 구현하도록 하겠습니다.

@skgndi12 skgndi12 force-pushed the feature/issue-28/access-logging-on-http-server branch from edacbe3 to 3ea4f73 Compare June 3, 2023 05:25
isutare412
isutare412 reviewed Jun 3, 2023
View reviewed changes
api/src/controller/http/middleware.ts Outdated Show resolved Hide resolved
api/src/controller/http/server.ts Outdated Show resolved Hide resolved
@isutare412 isutare412 self-requested a review June 3, 2023 12:37
@isutare412 isutare412 changed the title [#28] Access logging on http server [#28] Access logging on HTTP server Jun 4, 2023
@isutare412
Copy link
Collaborator

고생하셨습니다 👍 👍

@skgndi12 skgndi12 force-pushed the feature/issue-28/access-logging-on-http-server branch from 1513a40 to 7a987ee Compare June 4, 2023 02:52
@skgndi12 skgndi12 merged commit 016b982 into MovieReviewComment:develop Jun 4, 2023
@skgndi12 skgndi12 deleted the feature/issue-28/access-logging-on-http-server branch June 18, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isutare412 isutare412 isutare412 approved these changes

Assignees

@skgndi12 skgndi12

Labels
api enhancement New feature or request
Projects
Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access logging on HTTP server
2 participants
@skgndi12 @isutare412