Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#127] Add Text component #138

Merged
merged 4 commits into from
Jan 30, 2024
Merged

[#127] Add Text component #138

merged 4 commits into from
Jan 30, 2024

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Jan 29, 2024

#127

Changes

  • UI에 보여지는 텍스트를 위한 컴포넌트 입니다.
  • 랜딩페이지에 사용될 유틸리티만 우선 고려했습니다.
  • 앞으로 추가될 다른 atomic 컴포넌트들과 마찬가지로 추후에 리팩토링을 거치면서 @mrc/common-components로 분리 예정입니다.

@2wheeh 2wheeh added enhancement New feature or request ui Something about UI labels Jan 29, 2024
@2wheeh 2wheeh self-assigned this Jan 29, 2024
@isutare412 isutare412 self-requested a review January 30, 2024 01:38
isutare412
isutare412 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 👍

@2wheeh 2wheeh merged commit aefecbc into MovieReviewComment:develop Jan 30, 2024
1 check passed
@2wheeh 2wheeh deleted the feature/issue-127/text branch January 30, 2024 11:00
@2wheeh 2wheeh mentioned this pull request Apr 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isutare412 isutare412 isutare412 approved these changes

@skgndi12 skgndi12 Awaiting requested review from skgndi12

Assignees

@2wheeh 2wheeh

Labels
enhancement New feature or request ui Something about UI
Projects
Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2wheeh @isutare412