Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#88] Implement issue passport #109

Merged
merged 3 commits into from
Jan 11, 2024
Merged

[#88] Implement issue passport #109

merged 3 commits into from
Jan 11, 2024

Conversation

skgndi12
Copy link
Collaborator

#88

Changes

  • Introduce packages for cookie
    • cookie-parser
    • @types/cookie-parser
  • Include JWT expiration value in HTTP configuration
  • Implement issue passport
    • Issue passport from cookie
    • Issue passport from header(RFC6750)

@skgndi12 skgndi12 added enhancement New feature or request api labels Jan 11, 2024
@skgndi12 skgndi12 self-assigned this Jan 11, 2024
isutare412
isutare412 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 👍

@skgndi12 skgndi12 merged commit 45487ef into MovieReviewComment:develop Jan 11, 2024
1 check passed
@skgndi12 skgndi12 deleted the feature/issue-88/implement-issue-passport branch January 11, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isutare412 isutare412 isutare412 approved these changes

@2wheeh 2wheeh Awaiting requested review from 2wheeh

Assignees

@skgndi12 skgndi12

Labels
api enhancement New feature or request
Projects
Alpha
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skgndi12 @isutare412