Improved number shortening to allow for decimal places #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved shortNumberFormat() function to allow for specifying number of decimal places as well as support for larger numbers.
Root3287
pushed a commit
to Root3287/NotEnoughUpdates
that referenced
this pull request
Oct 10, 2022
… mod when the chance from the repo does not meet simple percentage formatting (Moulberry#239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the shortNumberFormat() function to allow for the number of decimal places to be specified. This involved re-doing the way the function worked. Instead of using recursion, it now takes the log base 1000 of the number. It now also supports numbers up to 10²⁶.
By default, the function returns 1 dp like before, but I've changed it for damage indicators to show 2 dp instead. All the instances of the function have been replaced.