Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget "filter": strange behavior changing filter_cssFilter option #381

Closed
fabiomarchesi77 opened this issue Sep 28, 2013 · 3 comments
Closed
Labels

Comments

@fabiomarchesi77
Copy link

I'm using { theme : "bootstrap" } and { widgets : [ "filter"] }.

Everithing is ok but, if I change "filter_cssFilter" option, from "tablesorter-filter" to "form-control input-sm" (to use bootstrap css), filters stop to work!

Am I wrong?

@Mottie
Copy link
Owner

Mottie commented Sep 30, 2013

Hmm, I think it's because within the code, it uses filter_cssFilter to find the filter, but if it contains more than one class name, jQuery's find won't find it (i.e. $('table').find('.form-control input-sm') would likely return nothing because it assumes input-sm is an HTML tag.

I'll fix this issue in my next update. Thanks for reporting it!

@Mottie Mottie closed this as completed in 12ca586 Oct 11, 2013
@Mottie
Copy link
Owner

Mottie commented Oct 11, 2013

Hi @paladinodeimari!

Ok, all fixed. The default filter_cssFilter option is now an empty string. It is no longer used to find the filter elements as all filter elements get the class name "tablesorter-filter" added. That option will allow adding additional class names to the filters.

Thanks for reporting the problem!

@fabiomarchesi77
Copy link
Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants