Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreAccentsInResults option when searching with filter widget #357

Closed
davellanedam opened this issue Jul 28, 2013 · 7 comments
Closed

Comments

@davellanedam
Copy link

Hello Mottie, first of all, awesome work! and thank you very for giving it to the people!

I´ve been using your plugin for a while, everything was working great, but a few days ago i was using the filter widget feature on a table with spanish language data.

The problem is with the tildes, here it is:

If i search for "Bogota" (no accents) on the city column using the filter widget, i got no results at all, because the rows contain "Bogotá" (note the accented "a" letter).

So, can you please add ignoreAccentsInResults option to the search filter widget? i suggest option, because maybe not everybody would need it. But i think this option would be great for any other languages than spanish that use accents. Google does like that, you can search "Bogota" and it shows results with both "Bogota" and "Bogotá".

I wish this can be done, keep the good and nice work buddy!

@TheSin-
Copy link
Collaborator

TheSin- commented Jul 29, 2013

I thought this already existed, one sec while I try to find it.

@TheSin-
Copy link
Collaborator

TheSin- commented Jul 29, 2013

@TheSin- TheSin- closed this as completed Jul 29, 2013
@davellanedam
Copy link
Author

Thank you for answering, i know they work for sorting, but it doesn´t for FILTER SEARCH WIDGET, it sorts very nice, but when i search i get only results with no accents, thanks!

@TheSin- TheSin- reopened this Jul 29, 2013
@TheSin-
Copy link
Collaborator

TheSin- commented Jul 29, 2013

oh sorry about that, you are right they should get extended into searching, I'll see if I can extend it, might not get to this till later in the week though, thanks for being it in up.

@davellanedam
Copy link
Author

Thank you very much man for this great piece of code! Actually i didn´t think you could do this so fast, i was just suggesting a new cool feature for accented languages, again, thanks a lot!

@Mottie
Copy link
Owner

Mottie commented Oct 10, 2013

Hi @davellanedam!

Sorry for taking so long to respond, but I'll have this added in the next update!

@davellanedam
Copy link
Author

Hey Mottie! thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants