Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: validateOptions only if debug=true #1528

Closed
a-mair opened this issue Mar 19, 2018 · 1 comment
Closed

Feature Request: validateOptions only if debug=true #1528

a-mair opened this issue Mar 19, 2018 · 1 comment

Comments

@a-mair
Copy link
Contributor

a-mair commented Mar 19, 2018

Hi,

I think the title says it all: don't validateOptions if debugging is off to not wast time on start.
Another reason for that wish is that I fill widgetOptions when initializing tablesorter and later add/remove widgets (e.g. filter). This will flood the error log.
Or can you suggest a better way to temporarily enable/disable widgets? At the moment I use removeWidget and applyWidgetId.

Best regards,
Andreas

@Mottie
Copy link
Owner

Mottie commented Mar 19, 2018

Hi @a-mair!

This would be a reasonable change, now that you can debug each component. My intention was to reduce developer frustration, but yeah user perceived performance is more important.

@Mottie Mottie closed this as completed in 745229d Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants