Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipv6 Sorting Issues #1494

Closed
shiggins8 opened this issue Jan 10, 2018 · 3 comments
Closed

ipv6 Sorting Issues #1494

shiggins8 opened this issue Jan 10, 2018 · 3 comments

Comments

@shiggins8
Copy link

Hello, I have an issue where the ipv6 sorter is not working as expected. here is the list of ip addresses so that you can verify that it is not working correctly:

  • fd33:2222::101
  • fd33:2222::102
  • fd33:1111::103
  • fd33:1111::201
  • fd33:1111::203
  • fd33:1111::103
  • fd33:1111::101
  • fd33:1111::102

I have inspected the cache and see that each address is assigned a long decimal number that, in theory, should be correct, however the sorting on my site is incorrect. Any thoughts or reasons why these particular addresses would not sort properly?

@Mottie
Copy link
Owner

Mottie commented Jan 10, 2018

Hi @shiggins8!

Oh! I guess I forgot to consider the Number.MAX_SAFE_INTEGER when converting the ipv6 into a numerical value.

I'll get this problem fixed shortly.

@Mottie
Copy link
Owner

Mottie commented Jan 10, 2018

This has been fixed in v2.29.3 - demo

@shiggins8
Copy link
Author

Thank you very much, I appreciate your rapid response and all the great work on the plug in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants