Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct query validation exception messages fixes #844 #845

Merged
merged 1 commit into from
Sep 15, 2015

Conversation

shils
Copy link
Contributor

@shils shils commented Sep 9, 2015

No description provided.

@evanchooly
Copy link
Member

Could you add a test or two showing the case in error? There are often multiple code paths to any point in code and we need to make sure we're addressing them correctly.

@shils
Copy link
Contributor Author

shils commented Sep 9, 2015

Sure, would you prefer an amended commit or a separate one?

@evanchooly
Copy link
Member

Amended is fine. Thanks so much.

--------------------------------

{ *name : *"Justin Lee", *
title : *"Software Engineer"
,
twitter : "@evanchooly http://twitter.com/evanchooly_"_,
web : [ "mongodb.com http://www.mongodb.com", "antwerkz.com"
],
location : "New York, NY" }

On Wed, Sep 9, 2015 at 11:22 AM, Shil Sinha [email protected]
wrote:

Sure, would you prefer an amended commit or a separate one?


Reply to this email directly or view it on GitHub
#845 (comment).

@shils shils force-pushed the fix-query-validation-messages branch from 6ec0f22 to c9a8f5f Compare September 9, 2015 23:21
@shils
Copy link
Contributor Author

shils commented Sep 9, 2015

Amended with tests for both cases.

@shils shils force-pushed the fix-query-validation-messages branch from c9a8f5f to 61a00e2 Compare September 10, 2015 00:07
@evanchooly evanchooly added the bug label Sep 15, 2015
@evanchooly evanchooly added this to the 1.1.0 milestone Sep 15, 2015
evanchooly added a commit that referenced this pull request Sep 15, 2015
correct query validation exception messages fixes #844
@evanchooly evanchooly merged commit dc0745c into MorphiaOrg:master Sep 15, 2015
@evanchooly
Copy link
Member

Looks great. Thanks for the patch. good catch.

@shils shils deleted the fix-query-validation-messages branch October 6, 2015 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants