when collecting index definitions, look at the parent classes as well… #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as the nested types for definitions. don't create indexes when the mapped class is abstract. fixes #1086
rozza
reviewed
Dec 8, 2016
| List<DBObject> indexInfo = getDs().getCollection(IndexedClass.class) | ||
| .getIndexInfo(); | ||
| assertEquals("Should have 5 indexes", 5, indexInfo.size()); |
There was a problem hiding this comment.
How come this check was removed - shouldn't there be a fixed number of indexes?
There was a problem hiding this comment.
Well my initial thought was we'd catch any extra indexes in the loop but that won't catch missing indexes so I'll restore that check.
rozza
reviewed
Dec 8, 2016
| @@ -129,22 +131,27 @@ public void createIndex() { | |||
| assertEquals(parse("{ 'nest.name' : 1} "), dbObject.get("key")); | |||
| } else if (name.equals("searchme")) { | |||
| assertEquals(parse("{ 'text' : 10 }"), dbObject.get("weights")); | |||
| } else if (name.equals("indexName_1")) { | |||
There was a problem hiding this comment.
Checkstyle probably is complaining about the "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as the nested types for definitions.
don't create indexes when the mapped class is abstract.
fixes #1086