You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is an issue for compiling a list of breaking API changes that would be nice to have, but arent really worth doing on their own. The plan is to save them all up and apply them all at once whenever version 1.0 is considered ready.
The list:
rename the model classes to have more descriptive names
give all the model classes a consistent API (and maybe create some superclass or interface for this?)
make the parse() methods on each class generic (using fields and methods defined by the model classes) and pull it up into a superclass for deduplication
convert the constructor of the Days class to a class method from_range and make a simpler constructor (this will require some pretty major refactoring)
make is_24_hr() and is_12_hour() in Time consistent
create a common system for specifying assumptions to make when the information is not available (for AM/PM, and century/year)
make all the from_parse_results methods consistent with regard to if they are processing a clean dictionary or a pyparsing.ParseResult object and possibly rename them to from_parse_result_dict
The text was updated successfully, but these errors were encountered:
MoralCode
added
the
discussion
issues or PR's created for future planning or soliciting feedback and discussion
label
Jul 4, 2021
This is an issue for compiling a list of breaking API changes that would be nice to have, but arent really worth doing on their own. The plan is to save them all up and apply them all at once whenever version 1.0 is considered ready.
The list:
parse()
methods on each class generic (using fields and methods defined by the model classes) and pull it up into a superclass for deduplicationDays
class to a class methodfrom_range
and make a simpler constructor (this will require some pretty major refactoring)Times
toTimeRange
and create a classTimes
that can store multipleTimeRange
's similar toDays
(see support several opening and closing times for a single day #5)is_24_hr()
andis_12_hour()
inTime
consistentfrom_parse_results
methods consistent with regard to if they are processing a clean dictionary or apyparsing.ParseResult
object and possibly rename them tofrom_parse_result_dict
The text was updated successfully, but these errors were encountered: