Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a tool that produces code quality metrics and reports code smells #98

Closed
4 tasks done
CSchoel opened this issue Jul 15, 2021 · 2 comments · Fixed by #116
Closed
4 tasks done

Set up a tool that produces code quality metrics and reports code smells #98

CSchoel opened this issue Jul 15, 2021 · 2 comments · Fixed by #116
Assignees

Comments

@CSchoel
Copy link
Contributor

CSchoel commented Jul 15, 2021

  • Register the project in a code quality tool like SonarQube or LGTM
    • Suggested sources for help: help page of LGTM, the SCM team (in order to obtain rights to create a SonarQube project)
  • Configure SonarQube/LGTM so that it shows as much meaningful information as possible
  • If necessary, ensure that the code quality is checked for every commit to the main branch
  • Add a badge for the overall code quality of the project to the README
@CSchoel
Copy link
Contributor Author

CSchoel commented Jul 26, 2021

I have set up a SonarQube project fort this: https://scm.thm.de/sonar/dashboard?id=MopeSWTP-SS21

However, I still need to fix the errors in feature/sonarQube in order to incorporate the code quality check into our CI pipeline.

This was referenced Jul 26, 2021
@CSchoel
Copy link
Contributor Author

CSchoel commented Aug 2, 2021

I created another pull request that also enables code coverage via SonarQube. I also went through all SonarQube settings and tried to increase the amount of checks that were being done, but apparently there is only very coarse support for selecting which things should be checked.

@CSchoel CSchoel closed this as completed Aug 2, 2021
@CSchoel CSchoel mentioned this issue Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants