Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMC is never shut down #76

Closed
CSchoel opened this issue Jun 28, 2021 · 3 comments
Closed

OMC is never shut down #76

CSchoel opened this issue Jun 28, 2021 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@CSchoel
Copy link
Contributor

CSchoel commented Jun 28, 2021

Steps to reproduce

  • Start server
  • Start console client, connect to server
  • Send initialize (option 1)
  • Send exit (option 9)
  • Shutdown server process by pressing enter

Expected behavior

The OMC process started by the server should be shut down.

Actual behavior

The OMC process is still running.

This is probably relevant for #53 .

@CSchoel CSchoel added the bug Something isn't working label Jun 28, 2021
@manuEbg manuEbg assigned IlmarB and unassigned manuEbg Jul 3, 2021
@IlmarB
Copy link
Contributor

IlmarB commented Jul 5, 2021

right now the omc is shutdown by pressing enter, which as I did understand, should not be the case. I think the server shutdown should be the last step without any user interaction after he has pressed "9"

@CSchoel
Copy link
Contributor Author

CSchoel commented Jul 5, 2021

I'm not sure if sending the exit call to the server must be the last step here, since you have a multi-client server (see #53).

What is more important is that even when the server is manually shutdown by pressing enter, the compiler process is still running in the background. On Linux you can check this by typing ps -e | grep omc in the terminal. Currently the output looks like this:

   7287 ?        00:00:02 omc

The omc process is still running and must be killed manually by typing kill 7287. The server shutdown should already take care of this by sending the exit() command to the OMC.

@IlmarB
Copy link
Contributor

IlmarB commented Jul 11, 2021

Done - OMC is terminated after full shutdown

@IlmarB IlmarB closed this as completed Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants