Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shader error messages for OpenGL #7340

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Conversation

cpt-max
Copy link
Contributor

@cpt-max cpt-max commented Sep 1, 2020

If the capacity of the StringBuilder is not set, the error messages will be cut short to the default capacity, and memory behind the buffer get's corrupted.

@Jjagg Jjagg merged commit de07cb8 into MonoGame:develop Sep 1, 2020
@Jjagg
Copy link
Contributor

Jjagg commented Sep 1, 2020

Thanks @cpt-max! :)

kimimaru4000 pushed a commit to kimimaru4000/MonoGame that referenced this pull request Sep 25, 2020
Set StringBuilder capacity so it's large enough for shader error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants