-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed back button problems in UWP #5810
Conversation
It sounds right to me. @atomgott , MonoGame/MonoGame.Framework/WindowsUniversal/UAPGameWindow.cs Lines 340 to 364 in 589bcf4
This way we will have all Event Sync code nice and tide in one place. |
@atomgott Don't worry about the build failure, it's not because of this PR :) |
Oh ok :) |
You can see the diff without the whitespace changes by adding |
Great job @atomgott I just have to say that there's still a race condition although a very slim possibility of occurring. |
* Fixed back button race condition * Moved back button logic to UAPGameWindow.ProcessWindowEvents
* Fixed back button race condition * Moved back button logic to UAPGameWindow.ProcessWindowEvents
* Fixed back button race condition * Moved back button logic to UAPGameWindow.ProcessWindowEvents
* Fixed back button race condition * Moved back button logic to UAPGameWindow.ProcessWindowEvents
The back button on Windows 10 Mobile was not always reliable because GamePad.Back could be changed by the UI thread during a tick. Sometimes the button would do nothing because the game checked GamePadState before GamePad.Back was changed, which was reset to false in the end of the tick.