Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid debugging and assertions in wheels #74

Closed
ghost opened this issue Jul 6, 2020 · 5 comments
Closed

Avoid debugging and assertions in wheels #74

ghost opened this issue Jul 6, 2020 · 5 comments
Assignees
Labels
build automation Issues related to build automation and infrastructure
Milestone

Comments

@ghost
Copy link

ghost commented Jul 6, 2020

Describe the bug
Performance analysis indicates that the binary wheels probably are not build with debugging and assertions disables.
This gives a significant performance hit.

Software versions

  • OS and version: [e.g. Ubuntu 18.04]
  • Python version: [e.g. 3.7]
  • MonetDBe-Python version: [e.g. 0.7]
@ghost ghost added the build automation Issues related to build automation and infrastructure label Jul 6, 2020
@ghost ghost added this to the 0.8.2 milestone Jul 6, 2020
@gijzelaerr
Copy link
Collaborator

would adding -DCMAKE_BUILD_TYPE=Release be enough?

@gijzelaerr gijzelaerr self-assigned this Jul 7, 2020
@gijzelaerr gijzelaerr modified the milestones: 0.8.2, 0.9 Jul 7, 2020
@arjenderijke
Copy link
Contributor

That should be the solution, but it is not completely implemented in the CMake code of MonetDB. I will add that to my todo list.

@arjenderijke
Copy link
Contributor

BTW @mlkersten i would like to have the scripts you use for your performance analysis, to verify the implemented solution.

@njnes
Copy link
Member

njnes commented Jul 7, 2020

for now use
-DCMAKE_BUILD_TYPE=Release
-DASSERT=OFF

Last is enabled because we build 'a' non released hg/git checkout. If you build from a clean tar (ie no .hg/.git directory) the -DASSERT should not be needed.

@gijzelaerr gijzelaerr modified the milestones: 0.9, 0.8.3 Jul 8, 2020
@gijzelaerr
Copy link
Collaborator

0.8.3 with build type release has been published and uploaded to pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build automation Issues related to build automation and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants