-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Result --> SingleResult #155
Comments
@dgasmith Does this proposal interact at all with plans to make optimization a service? |
@mattwelborn No, doesn't effect those plans. Another option is to do:
Since these names are going to be typed many times I would be hesitant to make them too long where It seems that the main blocker is that |
I'm with @dgasmith here: It's clearer to use |
I've thought So any votes among the below? I'm plenty happy with SingleResult. It's distinctive but with a vague enough definition to not feel wrong stretching it.
|
|
|
Going with To drum up opinions, i'll query on a few more alternatives:
|
I'm in favor of syntactic simplicity where it can be found, so something like
|
@dotsdl Any thoughts on @mattwelborn Can you weigh in here? @leeping @j-wags Any thoughts here? I think your comments here would be quite valuable as you are not too deep into the ecosystem. |
Thanks for asking; after reading this discussion I think |
I strongly favor
with second choice
(or any combination thereof) |
It seems For the others:
|
Closed by #167, thank you everyone for the comments and feedback. |
So we've got
OptimizationInput
/Optimization
ResultInput
/Result
And in another project, I've got the potential for
FindifResultInput
/FindifResult
CBSResultInput
/CBSResult
etc. The optimization pair doesn't particularly signal "schema" to me. And it might be convenient to distinguish between the set of
*ResultInput
/*Result
pairs and the particular energy/gradient/hessian calc thatResultInput
/Result
now represents.It is suggested that the two first items above become the below so that the
*
of*ResultInput
/*Result
is never the empty string.OptimizationResultInput
/OptimizationResult
SingleResultInput
/SingleResult
(AnalyticResult
?)Please weigh in on this change, even if it's just an up/down emoji response.
The text was updated successfully, but these errors were encountered: