Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 89c2780 breaks java tests #7

Open
ngfgrant opened this issue Nov 25, 2019 · 3 comments
Open

Commit 89c2780 breaks java tests #7

ngfgrant opened this issue Nov 25, 2019 · 3 comments

Comments

@ngfgrant
Copy link
Contributor

Starting at 89c2780 the tests for the java example break. I am working on a fix.

@riteshtendulkar
Copy link
Contributor

Hi, can you please elaborate on what failure are you seeing?

image

@ngfgrant
Copy link
Contributor Author

gradle test

> Task :compileTestJava
Note: /Users/niallgrant/Codebase/modulr-hmac/samples/java/src/test/java/com/modulr/api/ModulrApiAuthTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :test FAILED

com.modulr.api.ModulrApiAuthTest > testHmacGeneratorWithDatSupplier FAILED
    org.mockito.exceptions.base.MockitoException at ModulrApiAuthTest.java:81
        Caused by: java.lang.UnsupportedOperationException at ModulrApiAuthTest.java:81
            Caused by: java.lang.IllegalArgumentException at ModulrApiAuthTest.java:81

com.modulr.api.ModulrApiAuthTest > testHmacGeneratorWithNonNullToken FAILED
    org.mockito.exceptions.base.MockitoException at ModulrApiAuthTest.java:37
        Caused by: java.lang.UnsupportedOperationException at ModulrApiAuthTest.java:37
            Caused by: java.lang.IllegalArgumentException at ModulrApiAuthTest.java:81

com.modulr.api.ModulrApiAuthTest > testHmacGeneratorWithNullToken FAILED
    org.mockito.exceptions.base.MockitoException at ModulrApiAuthTest.java:72
        Caused by: java.lang.UnsupportedOperationException at ModulrApiAuthTest.java:72
            Caused by: java.lang.IllegalArgumentException at ModulrApiAuthTest.java:81

3 tests completed, 3 failed

Running gradle test before 89c2780 passes the tests...

@ngfgrant
Copy link
Contributor Author

ngfgrant commented Nov 25, 2019

I've got a PR up that fixes things for me, along with some other minor refactoring. #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants