Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModernFlyouts opens when click MB4 or MB5 when playing LoL #88

Closed
NeoShinra opened this issue Oct 6, 2020 · 4 comments · Fixed by #113
Closed

ModernFlyouts opens when click MB4 or MB5 when playing LoL #88

NeoShinra opened this issue Oct 6, 2020 · 4 comments · Fixed by #113
Assignees
Labels
Bug Something isn't working Enhancement New feature or request Good First Issue Good for newcomers

Comments

@NeoShinra
Copy link

Hi! I just found that issue when playing LoL and is a little bit annoying. Every time I click MB4 or MB5, the volume slider opens like clicking the volume keys. In other games like Halo: MCC or other apps didn't happen. Hope you can solve it because I really love your app. Thanks for make Windows a better place ❤

@ShankarBUS
Copy link
Member

ShankarBUS commented Oct 6, 2020

Weird 🤔. I'll try to fix this.

Does this also happen while no apps are running?

@yume-chan
Copy link
Contributor

yume-chan commented Oct 16, 2020

Continuing from #98, after I casting the lParam to long it "works" now.

From my observation, mouse side buttons (and maybe some other keyboard keys, inferring from the doc) also generate a shell message.

And it slipped through the check here:

https://github.com/ShankarBUS/ModernFlyouts/blob/1063dd4f27318ec0b913a5340ee86b19182b1e71/ModernFlyouts/Flyout%20Helpers/AudioFlyoutHelper.cs#L147-L149

where isMediaKey is false and device is not null. I don't understand why you inverted the isMediaKey here.

@ShankarBUS
Copy link
Member

Thanks @yume-chan,

I didn't have time to debug and proper devices to test this. I am genuinely happy that you did the work for me 😄.

I don't understand why you inverted the isMediaKey here.

It's to check what the pressed key was (if it is not a media key i.e. it is a volume key, then check if the default audio device is present)

@ShankarBUS
Copy link
Member

Would you like to contribute? 😁😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or request Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants