Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lightgbm} v4.0.0 is coming #22

Closed
jameslamb opened this issue Jul 19, 2022 · 2 comments
Closed

{lightgbm} v4.0.0 is coming #22

jameslamb opened this issue Jul 19, 2022 · 2 comments

Comments

@jameslamb
Copy link

jameslamb commented Jul 19, 2022

👋 hey @mayer79 !

As you know from discussions we've had over in https://github.com/microsoft/LightGBM, at {lightgbm} has been accumulating breaking changes in preparation for a v4.0.0 release (microsoft/LightGBM#5153).

To make up for the fact that so many of these changes are being released directly without a deprecation cycle (microsoft/LightGBM#5133 (comment)), I'm willing to come here and contribute fixes to make {shapviz} compatible with both older and newer versions of {lightgbm}.

Are you open to such contributions?

I'd also be happy to document here in this issue how you and anyone contributing to this project can test it against the development version of LightGBM, if you think that'd help. (e.g., as I did here for {bonsai}: tidymodels/bonsai#34 (comment)).

Thanks so much for all your contributions to LightGBM and for maintaining this package that allows people to get more information out of their LightGBM models!

@mayer79
Copy link
Collaborator

mayer79 commented Jul 19, 2022

Hey James. Thanks so much. "shapviz" works for the current master as well as for the CRAN version, see my comment/snippet on SHAPforxgboost. I need to keep an eye on XGBoost though. They are planning to change the predict interface as well.

@mayer79 mayer79 closed this as completed Jul 19, 2022
@jameslamb
Copy link
Author

Excellent, glad to hear it! @ me in the future if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants