Fixing IncludeNonePublicMembers everywhere

* Fixing build * Fix IncludeNonePublicMembers everywhere
MoaidHathot · Feb 17, 2024 · eb40478 · eb40478
1 parent f9e5661
commit eb40478
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -86,7 +86,7 @@ public class AdditionValue
 }
 
 
-new AdditionValue(1, 2).Dump(members: new MembersConfig { IncludeFields = true, IncludeNonPublicMembers = true });
+new AdditionValue(1, 2).Dump(members: new MembersConfig { IncludeFields = true, IncludeNonePublicMembers = true });
 ```
 ![image](https://user-images.githubusercontent.com/8770486/232252840-c5b0ea4c-eae9-4dc2-bd6c-d42ee58505eb.png)
 

diff --git a/docs/readme/nuget.md b/docs/readme/nuget.md
@@ -73,7 +73,7 @@ public class AdditionValue
 }
 
 
-new AdditionValue(1, 2).Dump(members: new MembersConfig { IncludeFields = true, IncludeNonPublicMembers = true });
+new AdditionValue(1, 2).Dump(members: new MembersConfig { IncludeFields = true, IncludeNonePublicMembers = true });
 ```
 ![image](https://user-images.githubusercontent.com/8770486/232252840-c5b0ea4c-eae9-4dc2-bd6c-d42ee58505eb.png)
 

diff --git a/src/Dumpify.Playground/Program.cs b/src/Dumpify.Playground/Program.cs
@@ -1,5 +1,5 @@
 using Dumpify;
-
+using System.Buffers;
 using System.Collections;
 using System.ComponentModel;
 using System.Data;
@@ -26,14 +26,23 @@
 
 #pragma warning disable CS8321
 #pragma warning disable CS0168
+
 void TestSpecific()
 {
-    ((nuint)5).Dump();
-    ((nint)5).Dump();
-    'a'.Dump();
-    Enumerable.Range(0, 10).Select(i => (char)(i + 'a')).Dump();
-    Enumerable.Range(0, 10).Select(i => (char)(i + 'a')).ToArray().Dump();
-    "this is a string".Dump();
+    var moaid = new Person { FirstName = "Moaid", LastName = "Hathot", Profession = Profession.Software };
+    var moaid2 = new Person { FirstName = "Moaid", LastName = "Hathot", Profession = Profession.Software };
+
+    Person[] arr = [moaid, moaid];
+    arr.Dump();
+
+    //var value = SearchValues.Create("a");
+    //value.Dump();
+    // ((nuint)5).Dump();
+    // ((nint)5).Dump();
+    //'a'.Dump(typeNames: new TypeNamingConfig { });
+    // Enumerable.Range(0, 10).Select(i => (char)(i + 'a')).Dump();
+    // Enumerable.Range(0, 10).Select(i => (char)(i + 'a')).ToArray().Dump();
+    // "this is a string".Dump();
     //new TestVirtual().Dump();
     // DumpConfig.Default.TypeRenderingConfig.StringQuotationChar = '`';
     //
@@ -405,8 +414,8 @@ void ShowEverything()
 
     new Exception("This is an exception", new ArgumentNullException("blaParam", "This is inner exception")).Dump();
 
-    new AdditionValue(1, 10).Dump(members: new() { IncludeFields = true, IncludeNonPublicMembers = true, IncludeProperties = false });
-    new AdditionValue(1, 10).Dump(members: new() { IncludeFields = true, IncludeNonPublicMembers = true });
+    new AdditionValue(1, 10).Dump(members: new() { IncludeFields = true, IncludeNonePublicMembers = true, IncludeProperties = false });
+    new AdditionValue(1, 10).Dump(members: new() { IncludeFields = true, IncludeNonePublicMembers = true });
 
     //arr.Dump();
     //moaid.Dump();

diff --git a/src/Dumpify/Descriptors/ValueProviders/MemberProvider.cs b/src/Dumpify/Descriptors/ValueProviders/MemberProvider.cs
@@ -7,28 +7,28 @@ internal sealed record MemberProvider : IMemberProvider
     private readonly bool _includeProperties;
     private readonly bool _includeFields;
     private readonly bool _includePublicMembers;
-    private readonly bool _includeNonPublicMembers;
+    private readonly bool _includeNonePublicMembers;
 
     public MemberProvider()
         : this(true, false, true, false)
     {
 
     }
 
-    public MemberProvider(bool includeProperties, bool includeFields, bool includePublicMembers, bool includeNonPublicMembers)
+    public MemberProvider(bool includeProperties, bool includeFields, bool includePublicMembers, bool includeNonePublicMembers)
     {
         _includeProperties = includeProperties;
         _includeFields = includeFields;
         _includePublicMembers = includePublicMembers;
-        _includeNonPublicMembers = includeNonPublicMembers;
+        _includeNonePublicMembers = includeNonePublicMembers;
     }
 
     public IEnumerable<IValueProvider> GetMembers(Type type)
     {
         var flags = BindingFlags.Instance;
 
         flags |= _includePublicMembers ? BindingFlags.Public : BindingFlags.Default;
-        flags |= _includeNonPublicMembers ? BindingFlags.NonPublic : BindingFlags.Default;
+        flags |= _includeNonePublicMembers ? BindingFlags.NonPublic : BindingFlags.Default;
 
         var members = Enumerable.Empty<IValueProvider>();
 
@@ -60,9 +60,9 @@ public bool Equals(IMemberProvider? provider)
             return false;
         }
 
-        return _includeProperties == other._includeProperties && _includeFields == other._includeFields && _includePublicMembers == other._includePublicMembers && _includeNonPublicMembers == other._includeNonPublicMembers;
+        return _includeProperties == other._includeProperties && _includeFields == other._includeFields && _includePublicMembers == other._includePublicMembers && _includeNonePublicMembers == other._includeNonePublicMembers;
     }
 
     public override int GetHashCode()
-        => (_includeProperties, _includeFields, _includePublicMembers, _includeNonPublicMembers).GetHashCode();
+        => (_includeProperties, _includeFields, _includePublicMembers, _includeNonePublicMembers).GetHashCode();
 }