Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Test fail on node 4 with status code 137 #247

Closed
thangngoc89 opened this issue Mar 4, 2016 · 3 comments
Closed

Test fail on node 4 with status code 137 #247

thangngoc89 opened this issue Mar 4, 2016 · 3 comments
Assignees
Labels

Comments

@thangngoc89
Copy link
Contributor

https://travis-ci.org/MoOx/statinamic/jobs/113613499#L334


Update:

jamestalmage
Try without coverage.

Both nyc and ava are loading babel-core/register. In Node 4, npm does not dedupe by default, so nyc and ava may be resolving different instances of babel, so the hook may indeed be getting installed twice.

If it works without coverage, then it should just be a matter of removing —require babel-core/register from your npm script.

So there is 2 solutions here :

  • Don't run coverage on node 4
  • Remove --require and --all flags. (but we all know why do we add those flags in the first place)

@MoOx I wanna know your opinion about this.

@thangngoc89 thangngoc89 added the bug label Mar 4, 2016
@thangngoc89
Copy link
Contributor Author

Follow up istanbuljs/nyc#181

@MoOx
Copy link
Owner

MoOx commented Mar 4, 2016

Will remove --all and add empty test files that are just importing module. This will report 0% as we want to kick our own ass :D

@MoOx MoOx self-assigned this Mar 4, 2016
@thangngoc89
Copy link
Contributor Author

Ok. I'll continue to improve test coverage

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants