fix: remove stdout and stderr from error

The CLI test runner parses the TAP output from child processes now and displays it. This commit removes a previous workaround for displaying child process stdout and stderr when tests failures occurred. PR-URL: nodejs/node#45592 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> (cherry picked from commit fec0fbc333c58e6ebbd2322f5120830fda880eb0)
MoLow · Feb 2, 2023 · 5ba2500 · 5ba2500
1 parent 5f8ce61
commit 5ba2500
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/lib/internal/test_runner/runner.js b/lib/internal/test_runner/runner.js
@@ -1,4 +1,4 @@
-// https://github.com/nodejs/node/blob/f8ce9117b19702487eb600493d941f7876e00e01/lib/internal/test_runner/runner.js
+// https://github.com/nodejs/node/blob/fec0fbc333c58e6ebbd2322f5120830fda880eb0/lib/internal/test_runner/runner.js
 'use strict'
 const {
   ArrayFrom,
@@ -225,18 +225,13 @@ function runTestFile (path, root, inspectPort, filesWatcher) {
     const child = spawn(process.execPath, args, { signal: t.signal, encoding: 'utf8', env, stdio })
 
     let err
-    let stderr = ''
 
     filesWatcher?.watchChildProcessModules(child, path)
 
     child.on('error', (error) => {
       err = error
     })
 
-    child.stderr.on('data', (data) => {
-      stderr += data
-    })
-
     if (isUsingInspector()) {
       const rl = createInterface({ input: child.stderr })
       rl.on('line', (line) => {
@@ -257,7 +252,7 @@ function runTestFile (path, root, inspectPort, filesWatcher) {
       subtest.addToReport(ast)
     })
 
-    const { 0: { 0: code, 1: signal }, 1: stdout } = await SafePromiseAll([
+    const { 0: { 0: code, 1: signal } } = await SafePromiseAll([
       once(child, 'exit', { signal: t.signal }),
       toArray.call(child.stdout, { signal: t.signal })
     ])
@@ -268,8 +263,6 @@ function runTestFile (path, root, inspectPort, filesWatcher) {
           __proto__: null,
           exitCode: code,
           signal,
-          stdout: ArrayPrototypeJoin(stdout, ''),
-          stderr,
           // The stack will not be useful since the failures came from tests
           // in a child process.
           stack: undefined