Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Example scenes - Cannot move some scene description panels #104

Open
7 tasks
IssueSyncBot opened this issue Aug 20, 2023 · 1 comment · May be fixed by #930
Open
7 tasks

Fix Example scenes - Cannot move some scene description panels #104

IssueSyncBot opened this issue Aug 20, 2023 · 1 comment · May be fixed by #930
Assignees
@ghazen-ml
Labels
Status: In Progress Issue is actively being worked on. Type: Bug A problem with an existing feature that can be fixed with the next patched release.

Comments

@IssueSyncBot
Copy link

IssueSyncBot commented Aug 20, 2023 •
edited by ghazen-ml
Loading

Original issue opened by:

@shaynie @shaynie

Describe the bug

Other example scenes let you drag the entire scene contents by grabbing the description panel and moving it. In the Dialog Example scene the description panel is locked in place.

To reproduce

Steps to reproduce the behavior:

  1. Load the DialogExample/DictationExample scene in the Unity editor
  2. Run the scene
  3. Using input simulation, note that you cannot select the description panel.

Expected behavior

The description panel should be interactable and move the scene content.

Tasks

  • Fix Dictation Sample scene
  • Fix dialog example scene
  • Fix BoundsControl scene
  • Fix Clipping scene
  • Fix any other scenes
  • Non-Canvas Object Bar Example Scene
  • Non-Canvas UI Backplate Example Scene

ISSUE MIGRATION

Issue migrated from: microsoft/MixedRealityToolkit-Unity#11580
@IssueSyncBot IssueSyncBot added MRTK3 Type: Bug A problem with an existing feature that can be fixed with the next patched release. labels Aug 20, 2023
@AMollis AMollis removed the MRTK3 label Aug 20, 2023
@IssueSyncBot IssueSyncBot mentioned this issue Aug 24, 2023
Closed
@ghazen-ml
Copy link
Contributor

In addition to the panels sometimes not being moveable, many also let raycasts through to content behind. It may be nice to add a collider to all of these and then to in addition consider adding ObjectManipulation capability.

@ghazen-ml ghazen-ml added the Status: In Progress Issue is actively being worked on. label Dec 6, 2023
ghazen-ml added a commit to ghazen-ml/MixedRealityToolkit-Unity that referenced this issue Sep 23, 2024
@ghazen-ml
Samples: Improve consistency of description panel manipulation (Mixed…
13cc8de 
…RealityToolkit#104)

* Allow DescriptionPanel to be consistently grabbed in order to move
  the main scene content for that sample.

  - Update the DescriptionPanel prefab to include ObjectManipulator,
    UGUIInputAdapterDraggable, ConstraintManager and a BoxCollider.

* Update all scenes that reference DescriptionPanel to remove
  component duplication.

* Reference the parent "MixedRealitySceneContent" game object as the
  host transform when DescriptionPanels are moved.

* Removed some inconsistencies around game objects named
  "MixedRealitySceneContent", "SceneContent", "Content", "Examples",
  "Scene Content" to all be "MixedRealitySceneContent".
ghazen-ml added a commit to ghazen-ml/MixedRealityToolkit-Unity that referenced this issue Sep 24, 2024
@ghazen-ml
Samples: Improve consistency of description panel manipulation (Mixed…
a2e96e7 
…RealityToolkit#104)

* Allow DescriptionPanel to be consistently grabbed in order to move
  the main scene content for that sample.

  - Update the DescriptionPanel prefab to include ObjectManipulator,
    UGUIInputAdapterDraggable, ConstraintManager and a BoxCollider.

* Update all scenes that reference DescriptionPanel to remove
  component duplication.

* Reference the parent "MixedRealitySceneContent" game object as the
  host transform when DescriptionPanels are moved.

* Removed some inconsistencies around game objects named
  "MixedRealitySceneContent", "SceneContent", "Content", "Examples",
  "Scene Content" to all be "MixedRealitySceneContent".

* Add a rotation constraint to LegacyConstraintExamples scene content
  such that the content is always gravity aligned even after being
  moved via the description panel.
@ghazen-ml ghazen-ml linked a pull request Sep 24, 2024 that will close this issue
Open
ghazen-ml added a commit to ghazen-ml/MixedRealityToolkit-Unity that referenced this issue Sep 24, 2024
@ghazen-ml
Samples: Improve consistency of description panel manipulation (Mixed…
a45258b 
…RealityToolkit#104)

* Allow DescriptionPanel to be consistently grabbed in order to move
  the main scene content for that sample.

  - Update the DescriptionPanel prefab to include ObjectManipulator,
    UGUIInputAdapterDraggable, ConstraintManager and a BoxCollider.

* Update all scenes that reference DescriptionPanel to remove
  component duplication.

* Reference the parent "MixedRealitySceneContent" game object as the
  host transform when DescriptionPanels are moved.

* Removed some inconsistencies around game objects named
  "MixedRealitySceneContent", "SceneContent", "Content", "Examples",
  "Scene Content" to all be "MixedRealitySceneContent".

* Add a rotation constraint to LegacyConstraintExamples scene content
  such that the content is always gravity aligned even after being
  moved via the description panel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghazen-ml ghazen-ml

Labels
Status: In Progress Issue is actively being worked on. Type: Bug A problem with an existing feature that can be fixed with the next patched release.
Projects
None yet
Milestone
No milestone
3 participants
@AMollis @ghazen-ml @IssueSyncBot