-
-
Notifications
You must be signed in to change notification settings - Fork 924
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental attempt to remove need to have RouteResolver
in core
#2073
Comments
So if I could get access to that primitive, I could factor the entire mess out of core and into a third-party library. (Smaller core is always a plus IMHO.) |
This came as a product of a Gitter conversation with @barneycarroll, BTW. |
Alternatively, we could provide a method to just get the default route, and I could just use |
@isiahmeadows this is not equivalent to RouteResolvers: It will not preserve layouts on route change, and will not keep the previous endpoint live while the async route is pending. |
Ugh...I made a few edits to make it wrap |
An easier alternative would be to make every route an As for route resolvers, with render functions (instead of render components) whose vnodes are diffed on route change, that would make my bit a little easier - I could write it as a simple component instead, without having to wrap anything. It'd also have benefits for those using common base layout components, as those would simply diff, and they wouldn't need to wrap |
Update: no Edit: So a userland wrapper would just call However, we would want to move |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
People have been having weird issues and pretty specialized needs that route resolvers alone can't deal with. Also, I managed to reduce it to using only a single extra, trivial primitive that simply redirects to the default route (without having to trigger a hash change or anything like that).
The text was updated successfully, but these errors were encountered: