Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building themes requires path to scheme and template #45

Open
heygsiri opened this issue Dec 29, 2021 · 3 comments
Open

Building themes requires path to scheme and template #45

heygsiri opened this issue Dec 29, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@heygsiri
Copy link

Hi,

I have been tinkering with flavours to make my color configs flexible. Updating, applying, and generating schemes have been a breeze so far. However, building seems to have an issue: I have to provide a path to the .mustache or .yaml files for the scheme and template, otherwise the build command won't work.

Kindly see the asciicast below for an example with scheme nord and template i3. Applying the themes goes seamlessly (although you won't see it due to limitations of asciicinema), but I struggle to build a scheme.

asciicast

I do not have Rust experience although I am more than happy to answer questions to help make this awesome software more awesome 😄.

@heygsiri heygsiri changed the title Building templates requires path to scheme and template Building themes requires path to scheme and template Dec 29, 2021
@Misterio77
Copy link
Owner

Hey!

This is currently intended, as flavours build is a "plumbing command" (intended for use in scripts) that acts as a standalone builder. Meaning it doesn't depend on the caller having a flavours config nor a flavours-managed data directory.

Just to clarify, you don't need to build before applying (applying builds for you, based on your flavours config and data dir). Should you want to script something with flavours build, flavours list can help (it can list scheme paths), and in the future #35 should help too.

@heygsiri
Copy link
Author

Thank you for the response.

I am aware that I do not need to build before applying. For now I use flavours build to get a glimpse of the output which helps in planning where the color configuration goes into. Perhaps a switch (such as flavours build -a) to assume the current schemes and templates path?

@Misterio77
Copy link
Owner

Hey, sorry for the delay.

This switch would indeed pretty nice. I'll see if i can get it implemented soonish :)

@Misterio77 Misterio77 added enhancement New feature or request good first issue Good for newcomers labels Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants