Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): EntityServiceなどでDB照会の結果を短時間キャッシュするように #477

Open
wants to merge 1 commit into
base: io
Choose a base branch
from

Conversation

u1-liquid
Copy link
Member

@u1-liquid u1-liquid commented Feb 25, 2024

What

resolve #472

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@u1-liquid u1-liquid force-pushed the cache-database-entityservice branch 3 times, most recently from b9b78be to c1ce9af Compare February 25, 2024 20:48
@u1-liquid u1-liquid force-pushed the cache-database-entityservice branch from c1ce9af to 8b1f30a Compare March 4, 2024 23:14
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
9.9% Duplication on New Code

See analysis details on SonarCloud

@u1-liquid
Copy link
Member Author

他の作業が優先になるのでメモ
一旦今の実装は没にして
なんでも目当てのentityをfetchできるLRU付きのcontextクラスを作ってそいつをentityserviceの間に共有する形にする
optionalにして、undefinedなら初めて呼び出されたentityserviceが勝手にcontextを作ってそれから呼び出す他のentityserviceに共有する感じ
ただしcontext自体はずっと残したりはしないのでTTLとかキャッシュのpurge処理などはいらない
packManyのことも考慮するとこれが一番手っ取り早いかも

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EntityServiceのクエリーの数を減らす
1 participant