Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support branch coverage measurement in the coverage PR comment #110

Open
kevalmorabia97 opened this issue Jan 23, 2023 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@kevalmorabia97
Copy link

Feature request: Is it possible to have a config parameter to show the table with branch coverage measurement as well?
Currently the coverage percentage does not consider branch percentage. But if someone uses --branch flag in the coverage command or branch=True in setup.cfg, the table that this action posts would not be consistent with the table that pytest-cov prints out
image

@MishaKav
Copy link
Owner

Good idea, I will check the possibility to add this feature when got some time.

@MishaKav
Copy link
Owner

MishaKav commented Mar 4, 2023

I checked the ability and even tried to add this feature.
For now, it's tough, because it is written in pure javascript without any tests, so I scary to break things.

I think, that first of all when I will get some time, I will try to rewrite this action in typescript with strong UTs, then I will be able to add new powerful features like that without feeling that I may break things.

@vgpastor
Copy link

+1

@PeterKogan
Copy link

+1

This action is great and that's the only feature I'm missing

@MishaKav MishaKav added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants