New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make selector variable. #84

Open

Tjoosten opened this issue Apr 7, 2018 · 0 comments

Collaborator

Tjoosten commented Apr 7, 2018 •

edited

Loading

For now the selector in the where statement is hardcoded. This is a bad practice.
This should by coded with a variable. That defaults to =

L5.x-database-layering/src/ActivismeBE/Repositories/Eloquent/Repository.php

Line 308 in fe464c6

public function findBy($attribute, $value, $columns = ['*'])

L5.x-database-layering/src/ActivismeBE/Repositories/Eloquent/Repository.php

Line 323 in fe464c6

public function findAllBy($attribute, $value, $columns = ['*'])

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment