Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InterestManagementBase): Improve SetHostVisibility #3949

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

MrGadget1024
Copy link
Collaborator

@MrGadget1024 MrGadget1024 commented Nov 22, 2024

Tested in Additive Levels example by adding terrains with tree details, spot lights, audio sources, and particle systems to each of the two subscenes. Turn sound on / unmute the audio when playing the video below.

  • Note that this is a virtual method, works by default for all interest mgmt, and can be overridden.
2024-11-22.13-30-35.mp4

@miwarnec
Copy link
Collaborator

definitely useful. also risky since it would introduce new behaviour to all existing mirror projects (i.e. why are my lights suddenly changing?).

probably best to just leave this as virtual and studios can override to implement what they need.

@MrGadget1024
Copy link
Collaborator Author

That means a custom IM that user has to create because we don't handle the stuff we should out of the box. Not at all user friendly. They'd have to somehow learn that they even can create a custom IM, even with our template, copy the entire IM from one of ours, and then add the override for this stuff. How would users even know to do this?

@MrGadget1024
Copy link
Collaborator Author

How about an alternative, where IM has drop-down flags for what to handle?

@miwarnec miwarnec merged commit a10dc60 into master Nov 29, 2024
3 checks passed
@miwarnec miwarnec deleted the FixSetHostVisibility branch November 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants