Removing images does not appear to be working correctly

[afbjorklund]

There is no error reported in crictl, but the image still remains.

sudo crictl rmi ...

There seems to be an internal error in the log, about a reference ?

The image reference ... was not a digest reference

[afbjorklund]

The code makes some assumptions, on the return value when returning an error:

        imageInspect, err := ds.client.InspectImageByID(image.Image)

        // dockerclient.InspectImageByID doesn't work with digest and repoTags,
        // it is safe to continue removing it since there is another check below.
        if err != nil && !libdocker.IsImageNotFoundError(err) {
                return nil, err
        }

        if imageInspect == nil {
                // image is nil, assuming it doesn't exist.
                return &runtimeapi.RemoveImageResponse{}, nil
        }

The code comment explaining the current behaviour has been deleted... 8737219

        // TODO: We assume image.Image is image ID here, which is true in the current implementation
        // of kubelet, but we should still clarify this in CRI.

Unfortunately, it doesn't work with the short Id from the crictl output. Only the full id.

[afbjorklund]

Should only be an issue when user runs the crictl manually, the kubelet uses full Id.