Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type declaration for TypeScript #18

Open
kelreel opened this issue Feb 27, 2020 · 1 comment
Open

Add type declaration for TypeScript #18

kelreel opened this issue Feb 27, 2020 · 1 comment
Labels
Hacktoberfest Encourage contributions to participate in Hacktoberfest event help wanted Extra attention is needed

Comments

@kelreel
Copy link
Contributor

kelreel commented Feb 27, 2020

It would be great to add the d.ts file to the SDK. (Now this is not, including in @types /minter-js-sdk). I could try to do this, but I doubt the correctness.
Maybe you already have a type description that is not included in the repository, then you could add a link to this in the documentation.
@shrpne
Copy link
Member

shrpne commented Feb 27, 2020

Hi, nice idea.
Currently, I don't have any ts types, but minter-js-sdk pretty well covered by jsdoc. I guess there should be tools for generating d.ts from jsdoc. I'll try to investigate it when I have time.

@shrpne shrpne added Hacktoberfest Encourage contributions to participate in Hacktoberfest event help wanted Extra attention is needed labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest Encourage contributions to participate in Hacktoberfest event help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shrpne @kelreel