Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MINERvA-specific code/classes (and add to MAT-MINERvA) #2

Open
bamesserly opened this issue Jul 11, 2021 · 2 comments
Open

Remove MINERvA-specific code/classes (and add to MAT-MINERvA) #2

bamesserly opened this issue Jul 11, 2021 · 2 comments

Comments

@bamesserly
Copy link
Collaborator

bamesserly commented Jul 11, 2021

Several classes in this repo have dependencies on classes that belong in MAT-MINERvA. As a band-aid solution, we moved those MAT-MINERvA classes back into this repo. But sooner rather than later we need to separate the dependencies and move the MINERvA classes back to their own repo.

In most cases, we need to perform open-heart surgery to extricate them. In other places (e.g. MnvH3D), the classes just need to be removed altogether. And there are other cases (e.g. HyperDimLinearizer) where the classes belong in this repo, but got added to MAT-MINERvA.

These classes should be removed from this repo and added to MAT:

  • FluxReweighter
  • FluxSystematics
  • MnvFluxConstraint
  • MnvColors

And these classes should be removed from this repo (and MAT-MINERvA for that matter) altogether:

  • MnvH3D
  • MnvVertErrorBand3D
  • MnvLatErrorBand
  • MnvLatErrorBand2D
  • MnvLatErrorBand3D

Return to this repo from MAT-MINERvA:

  • HyperDimLinearizer
  • PhysicsVariables
@bamesserly bamesserly linked a pull request Jul 11, 2021 that will close this issue
@bamesserly
Copy link
Collaborator Author

The macros and scripts directories also need to be organized.

@bamesserly
Copy link
Collaborator Author

Removing the code that I have already removed is not so simple bc UnfoldUtils depends on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant