Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of deprecated o1js functions #75

Open
kantp opened this issue Jul 2, 2024 · 2 comments
Open

Remove usage of deprecated o1js functions #75

kantp opened this issue Jul 2, 2024 · 2 comments
Assignees
@harrysolovay
Labels
audit Addresses findings from the audit info o1js Issues that require changes in o1js itself, rather than in this repository

Comments

@kantp
Copy link
Collaborator

kantp commented Jul 2, 2024

  • mina-fungible-token/FungibleToken.ts:

    • calculateCirculating() uses the isPositive() function to assert that the new computed total supply is non-negative. However, isPositive() has been deprecated in favor of isPositiveV2(), which does not suffer from multiple 0-representations.

  • o1js/mina-fungible-token/FungibleToken.ts:

    • TokenContract.transfer() uses the Int64.neg() function, which is deprecated in favor of negV2().
@kantp kantp added audit Addresses findings from the audit info labels Jul 2, 2024
@kantp kantp moved this to Todo in Fungible Token Audit Jul 2, 2024
@kantp kantp moved this from Todo to In Progress in Fungible Token Audit Jul 11, 2024
@harrysolovay harrysolovay mentioned this issue Jul 11, 2024
Merged
@harrysolovay
Copy link
Contributor

Blocked on o1-labs/o1js#1742

@harrysolovay harrysolovay moved this from In Progress to Blocked in Fungible Token Audit Jul 12, 2024
@kantp
Copy link
Collaborator Author

kantp commented Jul 18, 2024

The part of this that's in this repository is done, as calculateCirculating() has been removed.

@kantp kantp added the o1js Issues that require changes in o1js itself, rather than in this repository label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrysolovay harrysolovay

Labels
audit Addresses findings from the audit info o1js Issues that require changes in o1js itself, rather than in this repository
Projects
Fungible Token Audit
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kantp @harrysolovay