Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding storage to the Task MVP of TAD #32

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Adding storage to the Task MVP of TAD #32

merged 2 commits into from
Jun 6, 2024

Conversation

laurensWe
Copy link
Member

@laurensWe laurensWe commented Jun 6, 2024 •
edited
Loading

Description

Adding storage factory for writing to local file storage and writing a yaml to local file storage when a task is moved to done

Resolves #30

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@laurensWe laurensWe requested a review from a team as a code owner June 6, 2024 09:58
@laurensWe laurensWe mentioned this pull request Jun 6, 2024
Closed
5 tasks
uittenbroekrobbert
uittenbroekrobbert reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small remark. Up to you if you want to fix it.

tad/services/tasks.py Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@uittenbroekrobbert uittenbroekrobbert merged commit 04bcfdd into main Jun 6, 2024
11 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the cherrypick-rebase branch June 6, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurensWe @uittenbroekrobbert