Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move network configuration above estop.g call #47

Open
kohlerj opened this issue Oct 30, 2024 · 2 comments
Open

Move network configuration above estop.g call #47

kohlerj opened this issue Oct 30, 2024 · 2 comments

Comments

@kohlerj
Copy link
Contributor

kohlerj commented Oct 30, 2024

Hi!

I recently added a contactor to my Milo to avoid sending all those amps thru the E-Stop. My contactor has an NO channel which I wired back to my control board (GND and input with pull-up to detect cables brakes as an E-Stop signal).

I took the estop.g.example as an example but I had issues with the M582. Since I do not have a physical RESET button, I could not reset the stack in any other way than pressing the RESET button of the control board or power cycling my machine which I'd like to avoid because of the Pi running, display, etc.

Is there any reason why we cannot configure the network before going into the estop routine? Because then DWC is running and you can trigger the reset from the interface.

if { fileexists("network.g") }

@benagricola
Copy link
Member

Network configuration in RRF doesn't happen at the point where network.g runs. Nothing happens with the network until the configuration is completely loaded, which means reordering the network.g file to be above the optional estop.g wouldn't do anything.

The only thing you can change here is the line in the estop.g file which pauses startup if the estop is active, although removing that line would mean that a restart with the estop pressed would allow the machine to work as normal, which is not good.

@kohlerj
Copy link
Contributor Author

kohlerj commented Nov 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants