Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-81: Allow assert_that on not built-in types #81

Closed
MikeSchulze opened this issue Jun 5, 2021 · 0 comments · Fixed by #82
Closed

GD-81: Allow assert_that on not built-in types #81

MikeSchulze opened this issue Jun 5, 2021 · 0 comments · Fixed by #82
Assignees
@MikeSchulze
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
v0.9.6-rc

Comments

@MikeSchulze
Copy link
Owner

MikeSchulze commented Jun 5, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
I want to test against e.g. Color.red is equal Color.green.

# this line shows an error
assert_that(Color.red).is_equal(Golor.green)

'GdUnitObjectAssert inital error, unexpected type '

Describe the solution you'd like
assert_that() should allow to test against not built-in types

Describe alternatives you've considered
Workaround is to use str()

assert_str(str(Color.red)).is_equal(str(Color.green))
@MikeSchulze MikeSchulze self-assigned this Jun 5, 2021
@MikeSchulze MikeSchulze added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 5, 2021
@MikeSchulze MikeSchulze added this to the v1.0.0 milestone Jun 5, 2021
@MikeSchulze MikeSchulze changed the title Allow assert_that on not built-in types GD-81: Allow assert_that on not built-in types Jun 5, 2021
@MikeSchulze MikeSchulze linked a pull request Jun 5, 2021 that will close this issue
GD-81: Allow assert_that on not built-in types #82
Merged
@MikeSchulze MikeSchulze modified the milestones: v1.0.0, v0.9.6-rc Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSchulze MikeSchulze

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v0.9.6-rc
Development

Successfully merging a pull request may close this issue.

GD-81: Allow assert_that on not built-in types MikeSchulze/gdUnit3
1 participant
@MikeSchulze