Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-350: Spinner continues spinning after tests have stopped when debugging a single parameterised test #350

Closed
ZodmanPerth opened this issue Dec 25, 2022 · 0 comments · Fixed by #355
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ZodmanPerth
Copy link

ZodmanPerth commented Dec 25, 2022

The used Godot version:
v3.5.1.stable.official [6fed1ffa3]

OS including version:
Windows 11

Describe the bug
When debugging an individual parameterised test, if you stop execution before the end of the test run then the report shows that execution continues; the spinner keeps spinning and the individual test is shown in dark green.

Steps to Reproduce

  1. Use the parameterised test function provided below
  2. Run all tests
  3. Put a breakpoint on the assert_bool line
  4. Right-click one of the parameterised tests in the report window and select Debug Test
    image
  5. When the breakpoint is hit, stop the test with F8 or one of the UI stop buttons
  6. Observe the spinner on the test being debugged continues to spin even though tests have stopped (and the test is still dark green) as though it was still executing
    image

Minimal reproduction project:

func test_spinner(
	value : bool,
	expected : bool,
	test_parameters : Array = [
		[ true, true ],
		[ false, false ],
	]
):
	assert_bool(value).is_equal(expected)
@ZodmanPerth ZodmanPerth added the bug Something isn't working label Dec 25, 2022
@MikeSchulze MikeSchulze added this to the v2.3.2 milestone Dec 27, 2022
@MikeSchulze MikeSchulze changed the title Spinner continues spinning after tests have stopped when debugging a single parameterised test GD-350: Spinner continues spinning after tests have stopped when debugging a single parameterised test Dec 27, 2022
@MikeSchulze MikeSchulze moved this to In Progress in GdUnit3 Dec 28, 2022
@github-project-automation github-project-automation bot moved this from In Progress to Done in GdUnit3 Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants