Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock resource ARM template sample should use extension resource scopes #65815

Closed
anthony-c-martin opened this issue Nov 10, 2020 · 3 comments
Closed

Comments

@anthony-c-martin
Copy link
Contributor

We should update our ARM Template docs examples to consistently demonstrate the 'best practice' way to deploy extension resources - using the 'scope' property, rather than munging the 'type' and 'name' fields to generating a resourceId.

See this article for an example: https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/scope-extension-resources?tabs=azure-cli#apply-to-resource

In the example provided in this particular doc, I'd expect something like:

{
  "scope": "[concat('Microsoft.Web/sites', variables('siteName'))]",
  "type": "Microsoft.Authorization/locks",
  "name": "siteLock",
  ...
}

instead of:

{
  "type": "Microsoft.Web/sites/providers/locks",
  "name": "[concat(variables('siteName'), '/Microsoft.Authorization/siteLock')]",
  ...
}

@tfitzmac FYI


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@BharathNimmala-MSFT
Copy link
Contributor

@anthony-c-martin Thanks a lot for bringing this to our attention. I am assigning this issue to our document author @tfitzmac to further review and update the document accordingly.

@tfitzmac
Copy link
Contributor

@anthony-c-martin - thanks for this feedback. I have submitted an update that shows the new scope property. It should get published tomorrow morning.

@tfitzmac
Copy link
Contributor

#please-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants