Extensions are not npm_shrinkwrap'ed

[jrieken]

We have extensions that have npm dependencies, like css or json. We don't shrink-wrap them which means each build from the same commit has a chance of being different.

@Microsoft/vscode

[bpasero]

The list of extensions with node_modules folder:

• typescript @dbaeumer
• javascript @kieferrm
• php @aeschli
• markdown @kieferrm
• json @aeschli
• css @aeschli
• configuration-editing @jrieken
• node-debug @weinand

All of these need shrinkwrap and maybe a smoke test after that.

[bpasero]

Also, if you have recently moved code to a new extension, please make sure you have removed the dependency of your extension from our package.json and shrinkwrap file.

[jrieken]

@bpasero Can you give pointers how to create the shrink_wrap file?

[bpasero]

What I typically do is:

• Make sure to have npm 3 installed (to get a flat shrinkwrap file)
• Copy the package.json to a new, empty folder outside VSCode
• Delete all devDependencies from the package.json file
• Open a prompt in that new folder
• Run "npm install" and wait for it to finish without errors
• Run "npm shrinkwrap" and wait for it to finish without errors
• Copy the npm-shrinkwrap.json file into same location as the package.json file in the extension

[jrieken]

Since @aeschli is out, pls someone jump in. Also, we might need to run the OSS tool after this again 👻

[isidorn]

I can do it instead of @aeschli

[bpasero]

I updated the description with this important step:

• Copy the npm-shrinkwrap.json file into same location as the package.json file in the extension

[dbaeumer]

Done for TypeScript

[isidorn]

Seems to be done for all -> closing