Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: syntax highlighting for Pipfile and Pipfile.lock #995

Closed
hujianxin opened this issue Mar 9, 2018 · 3 comments · Fixed by #1975
Closed

Feature request: syntax highlighting for Pipfile and Pipfile.lock #995

hujianxin opened this issue Mar 9, 2018 · 3 comments · Fixed by #1975
Labels
feature-request Request for new features or functionality good first issue

Comments

@hujianxin
Copy link

It's great if this feature is integrated into vscode-python. Thanks
@DonJayamanne DonJayamanne added feature-request Request for new features or functionality good first issue needs PR labels Mar 9, 2018
@brettcannon
Copy link
Member

So a pipfile is TOML and a pipfile.lock is JSON, so we just need to add the appropriate associations. The latter is included in VS Code out of the box, but TOML isn't. The most popular TOML extension doesn't recoginize Pipfile, but I will send a PR for them to add it.

brettcannon added a commit to brettcannon/better-toml that referenced this issue Mar 9, 2018
@brettcannon
Recognize Python's Pipfile as a TOML file
48e635e 
To help address microsoft/vscode-python#995
@brettcannon brettcannon mentioned this issue Mar 9, 2018
Merged
@brettcannon
Copy link
Member

But in both instances we can add an association on our side as well to at least make it work when a TOML extension that has syntax highlighting is available.

@brettcannon
Copy link
Member

Or if you want to submit a PR to add the association, @hujianxin , that would be awesome 😄

n6g7 added a commit to n6g7/vscode-python that referenced this issue Jun 14, 2018
@n6g7
Associate pipenv files.
e3e2924 
Fixes microsoft#995.
This was referenced Jun 14, 2018
Closed
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pipenv syntax highlighting n6g7/vscode-python
3 participants
@brettcannon @DonJayamanne @hujianxin