Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert conda run work #9490

Closed
kimadeline opened this issue Jan 9, 2020 · 2 comments
Closed

Revert conda run work #9490

kimadeline opened this issue Jan 9, 2020 · 2 comments
Assignees
@kimadeline
Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug
Milestone
2019 December Spr...

Comments

@kimadeline
Copy link

kimadeline commented Jan 9, 2020 •
edited
Loading

Issues that were originally closed by the conda run work:

PRs impacted:

💡 Suggestion from @DonJayamanne:

Instead of reverting everything, simply turn it off:

  • modify createCondaExecutionService to return the same value as createActivatedEnvironment.
  • update CondaExecutionService to remove the overridden getExecutionInfo
@kimadeline kimadeline added bug Issue identified by VS Code Team member as probable bug needs PR area-environments Features relating to handling interpreter environments labels Jan 9, 2020
@kimadeline kimadeline added this to the 2019 December Sprint 2 milestone Jan 9, 2020
@kimadeline kimadeline self-assigned this Jan 9, 2020
@astrowonk
Copy link

I think this would resolve what I wrote up in #9484.

@kimadeline kimadeline mentioned this issue Jan 9, 2020
Merged
10 tasks
@karthiknadig karthiknadig mentioned this issue Jan 9, 2020
Closed
This was referenced Jan 9, 2020
Closed
Closed
@phloose phloose mentioned this issue Jan 9, 2020
Closed
This was referenced Jan 10, 2020
Closed
Closed
@kimadeline kimadeline mentioned this issue Jan 10, 2020
Closed
@karthiknadig karthiknadig mentioned this issue Jan 13, 2020
Closed
@kimadeline kimadeline mentioned this issue Jan 13, 2020
Closed
@kimadeline
Copy link
Author

Fixed in 2020.1.58038, see #9481 (comment)

@ghost ghost removed the needs PR label Jan 14, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kimadeline kimadeline

Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
2019 December Sprint 1
Development

No branches or pull requests
2 participants
@astrowonk @kimadeline