Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Altair plots don't look good in dark theme #2750

Closed
ronglums opened this issue Nov 7, 2019 · 2 comments
Closed

Altair plots don't look good in dark theme #2750

ronglums opened this issue Nov 7, 2019 · 2 comments
Assignees
@IanMatthewHuff

Comments

@ronglums
Copy link
Contributor

ronglums commented Nov 7, 2019

Looks great in light theme, but we probably need to adjust it for dark theme.
image
@rchiodo
Copy link
Contributor

rchiodo commented Nov 7, 2019

This would likely be a hack like we did for matplotlib. We'd have to inject extra code into an altair plot.

Or maybe we could just always have output with javascript in it have a white background.

@IanMatthewHuff IanMatthewHuff self-assigned this Nov 7, 2019
@rchiodo
Copy link
Contributor

rchiodo commented Nov 14, 2019

Validated.

@rchiodo rchiodo closed this as completed Nov 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@IanMatthewHuff IanMatthewHuff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IanMatthewHuff @rchiodo @ronglums