Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run above should run all code above, not just cells. #2753

Closed
rchiodo opened this issue Nov 6, 2019 · 3 comments
Closed

Run above should run all code above, not just cells. #2753

rchiodo opened this issue Nov 6, 2019 · 3 comments
Assignees

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Nov 6, 2019

In fact why does it need to run them as cells in the first place?

Related to issue microsoft/vscode-python#8392

@greazer greazer self-assigned this Nov 15, 2019
@greazer
Copy link
Member

greazer commented Nov 16, 2019

@gaetawoo, this issue was created in response to the discussion you had with @rchiodo in microsoft/vscode-python#8392. While this is a valid request, we have decided not to change this behavior. Why? Well, we have already shipped this way for a while. Therefore, if we change this, we could be affecting users who happened to find the current behavior satisfactory, or even desired. Given the problem is likely discoverable and easily worked around, as well, we just don't want to change it. We really appreciate your feedback though!

@greazer greazer closed this as completed Nov 16, 2019
@ghost
Copy link

ghost commented Nov 16, 2019

@greazer I wouldn't say it's really discoverable at all. And while it might be easy to work around, there is no indication as to why all code above doesn't run. You'd have to know a priori that only above cells will run. Maybe the label should be changed to be more precise. The only way I found out what the issue was was by chatting with a maintainer on a GitHub issue.

@rchiodo rchiodo reopened this Nov 20, 2019
@rchiodo rchiodo self-assigned this Dec 11, 2019
@IanMatthewHuff IanMatthewHuff self-assigned this Dec 14, 2019
@IanMatthewHuff
Copy link
Member

Validated.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 21, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants