Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's confusion around whether or not jupyterServerUri is required or not #2897

Closed
rchiodo opened this issue Oct 16, 2019 · 3 comments
Closed
Assignees

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Oct 16, 2019

Multiple bugs have been logged with people using localhost to run a server

There's also been bugs where people have thought just entering the jupyter server URI would startup jupyter.

I think at a minimum we need to rename this setting to include the word 'remote' and somehow make sure it's clear it's not necessary.

@greazer
Copy link
Member

greazer commented Oct 18, 2019

  1. We should rename this setting to be something like remoteJupyterUri.
  2. Fix quickpick so you can't type in the first step.

@IanMatthewHuff IanMatthewHuff self-assigned this Nov 1, 2019
@IanMatthewHuff
Copy link
Member

Validation notes:

Setting not changes (as we have to deprecate, which would ignore users old settings)
Quick Pick was totally removed from the flow
Wording was changed.

@rchiodo
Copy link
Contributor Author

rchiodo commented Nov 15, 2019

Not sure this is worth filing or not, but if you change the server URI after you've already connected, it has no effect. You have to restart VS code to get it to use the new URI.

Actually yeah I'll do that. Otherwise validated.

@rchiodo rchiodo closed this as completed Nov 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants