Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Editor - variable explorer functional test #3059

Closed
rchiodo opened this issue Sep 12, 2019 · 9 comments
Closed

Native Editor - variable explorer functional test #3059

rchiodo opened this issue Sep 12, 2019 · 9 comments
Assignees

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Sep 12, 2019

No description provided.

@rchiodo rchiodo self-assigned this Sep 30, 2019
@IanMatthewHuff IanMatthewHuff self-assigned this Oct 2, 2019
@IanMatthewHuff
Copy link
Member

Not validated. Looks like the variable explorer tests are failing on our flake build runs:

https://dev.azure.com/ms/vscode-python/_build/results?buildId=39756

@IanMatthewHuff IanMatthewHuff removed their assignment Oct 2, 2019
@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 2, 2019

Looks like the timing for waiting for the variable explorer on the native editor is inconsistent. I think we likely need a better way to tell when the variable explorer is finished. Maybe a message.

@DavidKutu
Copy link

The test 'Variable explorer - Loading (native)' fails on Windows.

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 7, 2019

What does it do?

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 7, 2019

The loading one is still flakey as it requires us to 'not' wait until all variables are ready

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 7, 2019

You can see it passes most of the time on the nightly flakey runs.

@DavidKutu
Copy link

I see but it fails consistently in my machine. If there is no solution for that test in particular maybe we can leave only that one with the flakey tests?

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 8, 2019

Or we can just look into making that test less flakey. Can you log a separate issue for that?

@DavidKutu
Copy link

Sure.
Validated.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants