Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async for and async with are not automatically indenting #7344

Closed
brettcannon opened this issue Sep 12, 2019 · 2 comments
Closed

async for and async with are not automatically indenting #7344

brettcannon opened this issue Sep 12, 2019 · 2 comments
Assignees
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug

Comments

@brettcannon
Copy link
Member

E.g.

async with ctxt:

and

async for x in y:

do not indent the next line after the :.

@brettcannon brettcannon added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Sep 12, 2019
@kimadeline
Copy link

kimadeline commented Sep 12, 2019

Our indentation on enter rules only cover async def:

beforeText: verboseRegExp(`
^
\\s*
(?:
(?:
(?:
class |
def |
async \\s+ def |
except |
for |
if |
elif |
while |
with
)
\\b .*
) |
else |
try |
finally
)
\\s*
[:]
\\s*
(?: [#] .* )?
$
`),
action: {

@kimadeline
Copy link

✅ Validated when building the extension from scratch (no new Insiders build since this PR got merged).

@ghost ghost removed the needs PR label Dec 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants