Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending telemetry for what language server is chosen #7109

Closed
karrtikr opened this issue Aug 27, 2019 · 6 comments
Closed

Sending telemetry for what language server is chosen #7109

karrtikr opened this issue Aug 27, 2019 · 6 comments
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@karrtikr
Copy link

python.jediEnabled is now changed to python.languageServer. Send telemetry for the startup value of this new setting.

@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Aug 27, 2019
@karrtikr karrtikr added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Aug 27, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Aug 27, 2019
@karrtikr karrtikr added triage-needed Needs assignment to the proper sub-team important Issue identified as high-priority and removed triage-needed Needs assignment to the proper sub-team labels Aug 27, 2019
@karrtikr karrtikr added this to the 2019 - August Sprint 16 milestone Aug 27, 2019
@karrtikr
Copy link
Author

karrtikr commented Aug 28, 2019

  • Modify function trackLangaugeServerSwitch to send telemetry for both startup and switch. Change the name of the function.

  • Modify telemetry regarding trackLangaugeServerSwitch to include new properties - startup/switchTo and the final state of setting python.languageServer.

@karrtikr
Copy link
Author

Can you validate this @luabud ? Try looking for event PYTHON_LANGUAGE_SERVER_CURRENT_SELECTION

@karthiknadig
Copy link
Member

Validated. These events are now available.
@luabud Are startUp and switchTo supposed to be separate events?

@DonJayamanne
Copy link

DonJayamanne commented Oct 19, 2019

The original issue comment makes mention of changes to the setting python.jediEnabled is now changed to python.languageServer

However this hasn't happened. So the telemetry shouldn't have changed!
I assumed this issue was to track the new setting with the values, Jedi, LS and none!

startUp and switchTo supposed to be separate

I thought these events had been around for a while.

@luabud
Copy link
Member

luabud commented Oct 21, 2019

The events are not available yet.

Are startUp and switchTo supposed to be separate events?

I expected it to be together to but it's find to leave it as separate.

However this hasn't happened. So the telemetry shouldn't have changed!

I don't think the idea was to drop the other telemetry point, but to add this one to get more info.

@luabud
Copy link
Member

luabud commented Oct 21, 2019

I talked to Karthik about it and since we're getting partial data for it, we can consider this validated. We'll track separately the "partial" problem.

@luabud luabud closed this as completed Oct 21, 2019
@ghost ghost removed the needs PR label Oct 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

6 participants