Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Strict mode #611

Closed
2 tasks
DonJayamanne opened this issue Jan 21, 2018 · 5 comments
Closed
2 tasks

Typescript Strict mode #611

DonJayamanne opened this issue Jan 21, 2018 · 5 comments
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

DonJayamanne commented Jan 21, 2018

  • Fix all tslint errors
  • Fix all typescript errors when compiled in strict mode
@DonJayamanne DonJayamanne added awaiting 2-PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Jan 21, 2018
@DonJayamanne DonJayamanne added this to the February 2018 milestone Jan 21, 2018
@elliott-beach
Copy link

elliott-beach commented Feb 4, 2018

I was wondering about this because linter errors often come up when editing.

Is this really an important, realistic goal? There are 1,763 errors from hygiene when run on the whole project, last I checked. Maybe fixing errors on each file as they are modified is more realistic.

@DonJayamanne
Copy link
Author

DonJayamanne commented Feb 4, 2018

Maybe fixing errors on each file as they are modified is more realistic.

That's been taken care of. Thats the current behavior.

The goal is to ensure PRs get rejected if linting falls. And we need to fix all errors,.

@DonJayamanne
Copy link
Author

1,763 that's interesting, I thought there were merely 500!!

@elliott-beach
Copy link

I might be confused, I'm referring to output of gulp hygiene, this is the output I get (ignoring warnings) https://gist.github.com/elliott-beach/2d3e76bff4cb1ff0355afee3d95704c5

@brettcannon
Copy link
Member

To help manage our issues and to better communicate what the team plans to work on we are closing issues that we don't plan to work on but would accept a pull request from a volunteer for. To be clear, closing this issue does not mean we won't consider a pull request for this enhancement as outlined in our contributing guide, just that the development team has no plans to work on it themselves.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 18, 2018
@brettcannon brettcannon reopened this Oct 22, 2018
@brettcannon brettcannon changed the title Fix all linter errors Fix all TypeScript linter errors Nov 13, 2018
@DonJayamanne DonJayamanne changed the title Fix all TypeScript linter errors Typescript Strict mode Jan 16, 2019
@d3r3kk d3r3kk added this to the 2019, week 3 - Jan Sprint 2 milestone Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

7 participants